lkml.org 
[lkml]   [2014]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] pcmcia: m8xx: remove checks for four macros
From
Date
On Sat, 2014-05-24 at 09:36 +0200, Paul Bolle wrote:
> This driver contains checks for four Kconfig macros. But the related
> Kconfig symbols have never been part of the tree. Remove these checks
> and the code they hide.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
>
> This has been an issue ever since this driver was added in v2.6.15. Note
> that there is no header named "*/cpld.h", so setting PRxK can't possibly
> work.
>
> drivers/pcmcia/m8xx_pcmcia.c | 75 --------------------------------------------
> 1 file changed, 75 deletions(-)

Does anything in this driver still work? It looks like bitrot from the
arch/ppc days, that sort of got updated to use the device tree -- but
even after this patch there are lots of instances of CONFIG symbols
being used to assert the exact hardware being used, rather than what
hardware is supported.

Is anyone actively maintaining/testing this code?

-Sott




\
 
 \ /
  Last update: 2014-05-29 21:21    [W:0.068 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site