Messages in this thread | | | Date | Thu, 29 May 2014 18:00:58 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH v4] gpio: Add support for Intel SoC PMIC (Crystal Cove) |
| |
On Thu, May 29, 2014 at 03:37:37PM +0200, Linus Walleij wrote: > My idea is that you should call gpiochip_add() *first* and then > add the IRQs to the chip. In succession. > > Rationale: with dynamic GPIO numbers, gpio_to_irq() > cannot reasonably be working before the gpiochip is added, > so it should be added first, then the irqchip. Since irq_to_gpio() > is *NOT* to be used (rather obliterated), this is the sequence > we mandate.
Thanks for the explanation. Makes sense.
I was wrong again, oh well it happens ;-)
| |