Messages in this thread | | | Date | Thu, 29 May 2014 15:44:59 +0200 | Subject | Re: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output | From | Linus Walleij <> |
| |
On Tue, May 27, 2014 at 9:26 PM, <eric.ernst@linux.intel.com> wrote:
> From: Eric Ernst <eric.ernst@linux.intel.com> > > For Baytrail, you should never set a GPIO set to direct_irq > to output mode. When direct_irq_en is set for a GPIO, it is > tied directly to an APIC internally, and making the pad output > does not make any sense. Assert a WARN() in the event this happens. > > Signed-off-by: Eric Ernst <eric.ernst@linux.intel.com>
Can I get some ACK from the author's of this driver on Eric's patch?
Eric, you *are* aware of what the gpio_lock_as_irq() and gpio_unlock_as_irq() in the .irq_request_resources are doing right? Is this patch just some extra safety measure?
Yours, Linus Walleij
| |