lkml.org 
[lkml]   [2014]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] remove duplicate checking code
From
Date
On Mon, 2014-05-26 at 11:39 +0200, Joerg Roedel wrote:
> On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote:
> > amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device
> > called before, it's fine to attach device at this point.
> >
> > Signed-off-by: Vaughan Cao <vaughan.cao@oracle.com>
> > ---
> > drivers/iommu/amd_iommu.c | 6 ------
> > 1 file changed, 6 deletions(-)
>
> Applied, thanks.

This one entered linux-next, as of next-20142527, in commit ecef115d4540
("iommu/amd: Remove duplicate checking code"). It triggers an obviously
correct warning:
drivers/iommu/amd_iommu.c: In function ‘amd_iommu_init_passthrough’:
drivers/iommu/amd_iommu.c:3503:6: warning: unused variable ‘devid’ [-Wunused-variable]
u16 devid;
^
drivers/iommu/amd_iommu.c:3502:20: warning: unused variable ‘iommu’ [-Wunused-variable]
struct amd_iommu *iommu;
^

Is the trivial fix for this queued somewhere?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-05-29 16:21    [W:0.089 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site