lkml.org 
[lkml]   [2014]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Input: touchscreen : Introduce the use of the managed version of kzalloc
    > > @@ -618,39 +619,22 @@ static int mrstouch_probe(struct platform_device *pdev)
    > > input_set_abs_params(tsdev->input, ABS_PRESSURE,
    > > MRST_PRESSURE_MIN, MRST_PRESSURE_MAX, 0, 0);
    > >
    > > - err = request_threaded_irq(tsdev->irq, NULL, mrstouch_pendet_irq,
    > > - IRQF_ONESHOT, "mrstouch", tsdev);
    > > + err = devm_request_threaded_irq(&pdev->dev, tsdev->irq, NULL,
    > > + mrstouch_pendet_irq, IRQF_ONESHOT,
    > > + "mrstouch", tsdev);
    > > if (err) {
    > > dev_err(tsdev->dev, "unable to allocate irq\n");
    > > - goto err_free_mem;
    > > + return -ENOMEM;
    >
    > This is bad conversion. We used to report 'err' returned by
    > request_threaded_irq, but now we always report -ENOMEM. I fixed it up
    > here and in other places and applied.

    Sorry to have missed that. I guess you got the one on the call to
    mrstouch_adc_init as well?

    thanks,
    julia


    \
     
     \ /
      Last update: 2014-05-29 10:01    [W:2.392 / U:0.660 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site