Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | Re: [PATCH] perf: fix 'make help' message error | Date | Thu, 29 May 2014 16:04:24 +0900 |
| |
Hi Jianyu,
On Sun, 25 May 2014 12:50:49 +0800, Jianyu Zhan wrote: > Currently 'make help' message has such hint: > > use "make prefix=<path> <install target>" to install to a particular > path like make prefix=/usr/local install install-doc > > But this is misleading, when I specify "prefix=/usr/local", it has got no > respect at all. Instead, what takes effect is the "DESTDIR" variable. > In this case, "DESTDIR" has a empty value, so the actual install > directory falls back $HOME, not '/usr/local'. > > Specifying "DESTDIR=/usr/local" will work as desired. > > This patch fixes the help message.
I don't know what's the correct way to do this. But it seems like the prefix was overwritten when given from user, so below patch will work also.
Thanks, Namhyung
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 729bbdf5cec7..80a8a0a1c7e7 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -599,7 +599,7 @@ endif # Make the path relative to DESTDIR, not to prefix ifndef DESTDIR -prefix = $(HOME) +prefix ?= $(HOME) endif bindir_relative = bin bindir = $(prefix)/$(bindir_relative)
| |