lkml.org 
[lkml]   [2014]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Unionmount and overlayfs testsuite
Date

David Howells:
> http://git.infradead.org/users/dhowells/unionmount-testsuite.git

I've found some interesting cases.

- impermissible.test,
open_file_as_bin -t -w $file -E EACCES
When $termslash is "/", a '/' is appended to the expanded $file, such
as "/path/fileA/". If fileA is a regular file, that path is obviously
wrong. Does UnionMount expect EACCES in this case too?
Should it be ENOTDIR?
It might be better to change
errcode=EACCES
test ! "$termslash" = "" && errcode=ENOTDIR
open_file_as_bin -t -w $file -E $errcode

- readlink.test,
fs_op readlink $file -R $testdir/direct_dir_sym100 ${termslash:+-E EINVAL}
It expects "$testdir/direct_dir_sym100". Does it mean UnionMount
converts the target path?
For example,
- /u = /rw + /ro
- /rw/symlinkA doesn't exist
- /ro/symlinkA points to /ro/fileA
Does readlink(2) return "/u/fileA" instead of "/u/fileA"?

And all tests should be done by a superuser?


J. R. Okajima


\
 
 \ /
  Last update: 2014-05-30 06:21    [W:0.448 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site