Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 10/26] perf ui/browser: Add support to accumulated hist stat | Date | Thu, 29 May 2014 08:52:54 +0900 |
| |
On Mon, 26 May 2014 19:52:26 +0200, Jiri Olsa wrote: > On Fri, May 23, 2014 at 07:04:07PM +0900, Namhyung Kim wrote: >> Print accumulated stat of a hist entry if requested. >> >> Tested-by: Arun Sharma <asharma@fb.com> >> Tested-by: Rodrigo Campos <rodrigo@sdfg.com.ar> >> Acked-by: Jiri Olsa <jolsa@redhat.com> >> Cc: Frederic Weisbecker <fweisbec@gmail.com> >> Signed-off-by: Namhyung Kim <namhyung@kernel.org> >> --- >> tools/perf/ui/browsers/hists.c | 26 +++++++++++++++++++++++++- >> 1 file changed, 25 insertions(+), 1 deletion(-) >> >> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c >> index 1c331b934ffc..1de7428a9771 100644 >> --- a/tools/perf/ui/browsers/hists.c >> +++ b/tools/perf/ui/browsers/hists.c >> @@ -632,7 +632,6 @@ static int __hpp__slsmg_color_printf(struct perf_hpp *hpp, const char *fmt, ...) >> ret = scnprintf(hpp->buf, hpp->size, fmt, percent); >> slsmg_printf("%s", hpp->buf); >> >> - advance_hpp(hpp, ret); >> return ret; > > Whats the purpose of this one..? does not fit to what's in changelog
Hmm.. looks like a rebase artifact. It's not a part of this patch. I'll remove it.
Thanks, Namhyung
| |