Messages in this thread | | | Date | Wed, 28 May 2014 00:24:04 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86, MCE: Flesh out when to panic comment |
| |
On Tue, May 27, 2014 at 09:53:56PM +0000, Luck, Tony wrote: > It is far from obvious that mce_severity() will always say that an > error detected inside the kernel will be fatal.
Oh yeah, it needs a good cleansing rewrite, that's for sure.
And this tolerant check looks fishy to me:
if (s->sev >= MCE_UC_SEVERITY && ctx == IN_KERNEL) { if (panic_on_oops || tolerant < 1) return MCE_PANIC_SEVERITY; }
since we set it to 1 by default. But I'll look again on a clear head tomorrow - it is too late here.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |