| From | Alexander Shiyan <> | Subject | Re: [PATCH 09/27] mtd: nand: pxa3xx: show dev ice structure in sysfs | Date | Tue, 27 May 2014 07:12:21 +0400 |
| |
Tue, 27 May 2014 00:12:34 +0200 от Alexander Holler <holler@ahsoftware.de>: > Fix a common error in nand-drivers which do not set up a parent device for > the mtd-device by using a new inline function. > > Signed-off-by: Alexander Holler <holler@ahsoftware.de> > --- > drivers/mtd/nand/pxa3xx_nand.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > index 7588fe2..7f62e7c 100644 > --- a/drivers/mtd/nand/pxa3xx_nand.c > +++ b/drivers/mtd/nand/pxa3xx_nand.c > @@ -1584,8 +1584,7 @@ static int alloc_nand_resource(struct platform_device *pdev) > host->mtd = mtd; > host->cs = cs; > host->info_data = info; > - mtd->priv = host; > - mtd->owner = THIS_MODULE; > + mtd_setup_common_members(mtd, host, pdev); > > chip->ecc.read_page = pxa3xx_nand_read_page_hwecc; > chip->ecc.write_page = pxa3xx_nand_write_page_hwecc; > --
Should we add "driver.owner = THIS_MODULE" field for struct platform_driver in this case?
---
|