lkml.org 
[lkml]   [2014]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 12/14] perf tests: Add test interface for dso data fd limit
Date
On Thu, 15 May 2014 19:23:33 +0200, Jiri Olsa wrote:
> Adding a way to setup test dso limit by global variable
> test_dso_data__fd_limit. It'll be used in the dso data
> cache tests.

Why is this needed? Why not justing setting RLIMIT_NOFILE in the test
cases?

Thanks,
Namhyung

>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Jean Pihet <jean.pihet@linaro.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/util/dso.c | 5 +++++
> tools/perf/util/dso.h | 3 +++
> 2 files changed, 8 insertions(+)
>
> diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
> index 80b54e7..9310369 100644
> --- a/tools/perf/util/dso.c
> +++ b/tools/perf/util/dso.c
> @@ -7,6 +7,8 @@
> #include "util.h"
> #include "debug.h"
>
> +rlim_t test_dso_data__fd_limit;
> +
> char dso__symtab_origin(const struct dso *dso)
> {
> static const char origin[] = {
> @@ -262,6 +264,9 @@ static bool may_cache_fd(void)
> if (!limit)
> limit = get_fd_limit();
>
> + if (unlikely(test_dso_data__fd_limit))
> + limit = test_dso_data__fd_limit;
> +
> if (limit == RLIM_INFINITY)
> return true;
>
> diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h
> index d713184..3807014 100644
> --- a/tools/perf/util/dso.h
> +++ b/tools/perf/util/dso.h
> @@ -1,6 +1,7 @@
> #ifndef __PERF_DSO
> #define __PERF_DSO
>
> +#include <sys/resource.h>
> #include <linux/types.h>
> #include <linux/rbtree.h>
> #include <stdbool.h>
> @@ -8,6 +9,8 @@
> #include "map.h"
> #include "build-id.h"
>
> +extern rlim_t test_dso_data__fd_limit;
> +
> enum dso_binary_type {
> DSO_BINARY_TYPE__KALLSYMS = 0,
> DSO_BINARY_TYPE__GUEST_KALLSYMS,


\
 
 \ /
  Last update: 2014-05-27 04:01    [W:0.177 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site