lkml.org 
[lkml]   [2014]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] lib/debugobjects.c: code clean-up
On Sat, May 24, 2014 at 03:08:06PM +0200, Fabian Frederick wrote:
> Fix some checkpatch warnings.
>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Some of these make sense, one of them does not. Comments below.

Also, please explicitly note the checkpatch warnings you fixed, not just
"Fix some checkpatch warnings.".

> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
[...]
> @@ -415,7 +415,8 @@ int debug_object_activate(void *addr, struct debug_obj_descr *descr)
> debug_print_object(obj, "activate");
> state = obj->state;
> raw_spin_unlock_irqrestore(&db->lock, flags);
> - ret = debug_object_fixup(descr->fixup_activate, addr, state);
> + ret = debug_object_fixup(descr->fixup_activate,
> + addr, state);

This does not seem like a worthwhile improvement. Please don't blindly
listen to checkpatch, especially regarding line lengths.

- Josh Triplett


\
 
 \ /
  Last update: 2014-05-25 00:41    [W:0.071 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site