Messages in this thread | | | From | Mike Turquette <> | Subject | Re: [PATCH] clk: st: Fix memory leak | Date | Fri, 23 May 2014 15:13:59 -0700 |
| |
Quoting Valentin Ilie (2014-04-22 06:15:54) > When it fails to allocate div, gate should be free'd before return > > Signed-off-by: Valentin Ilie <valentin.ilie@gmail.com>
Taken into clk-fixes.
Regards, Mike
> --- > drivers/clk/st/clkgen-pll.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c > index bca0a0b..a886702 100644 > --- a/drivers/clk/st/clkgen-pll.c > +++ b/drivers/clk/st/clkgen-pll.c > @@ -521,8 +521,10 @@ static struct clk * __init clkgen_odf_register(const char *parent_name, > gate->lock = odf_lock; > > div = kzalloc(sizeof(*div), GFP_KERNEL); > - if (!div) > + if (!div) { > + kfree(gate); > return ERR_PTR(-ENOMEM); > + } > > div->flags = CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO; > div->reg = reg + pll_data->odf[odf].offset; > -- > 1.8.3.2 >
| |