lkml.org 
[lkml]   [2014]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/2] irqchip: add Broadcom Set Top Box Level-2 interrupt controller
2014-05-22 18:51 GMT-07:00 Thomas Gleixner <tglx@linutronix.de>:
> On Thu, 22 May 2014, Florian Fainelli wrote:
>> +static void brcmstb_l2_intc_irq_handle(unsigned int irq, struct irq_desc *desc)
>> +{
>> + struct brcmstb_l2_intc_data *b = irq_desc_get_handler_data(desc);
>> + struct irq_chip *chip = irq_get_chip(irq);
>
> irq_desc_get_chip() is what you want here. irq_get_chip() is doing a
> full lookop of desc, which is silly as you have desc already.

Thanks, is there anything else that needs fixing before I submit a v3? Thanks!
--
Florian


\
 
 \ /
  Last update: 2014-05-23 23:01    [W:0.891 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site