Messages in this thread | | | Date | Sat, 24 May 2014 02:18:26 +0900 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 3/8] drivers/staging: Remove useless return variables |
| |
On Tue, May 20, 2014 at 12:33:43PM +0200, Peter Senna Tschudin wrote: > This patch remove variables that are initialized with a constant, > are never updated, and are only used as parameter of return. > Return the constant instead of using a variable. > > Verified by compilation only. > > The coccinelle script that find and fixes this issue is: > // <smpl> > @@ > type T; > constant C; > identifier ret; > @@ > - T ret = C; > ... when != ret > - return ret; > + return C; > // </smpl> > > Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
This patch no longer applies to my tree, can you refresh it and resend?
thanks,
greg k-h
| |