Messages in this thread | | | Date | Fri, 23 May 2014 20:16:25 +0900 | From | Greg KH <> | Subject | Re: [PATCH 2/2] staging: slicoss: handle errors from slic_config_get |
| |
On Thu, May 22, 2014 at 09:38:45PM -0700, David Matlack wrote: > slic_config_get() can fail. Change the return type from void to > int and handle the error in slic_card_init(). So now, instead of > silently failing (and then timing out waiting for the config data), > the driver will fail loudly at request time. > > Signed-off-by: David Matlack <matlackdavid@gmail.com> > --- > drivers/staging/slicoss/slicoss.c | 28 ++++++++++++++++------------ > 1 file changed, 16 insertions(+), 12 deletions(-)
It looks like I had already applied patch 1/2 here, but not this one, odd.
Anyway, I've applied this, and should be synced up with you now. If I have missed applying anything, please resend.
thanks,
greg k-h
| |