lkml.org 
[lkml]   [2014]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] ASoC: max98090: Add master clock handling
From
On 23 May 2014 16:44, Mark Brown <broonie@kernel.org> wrote:
> On Fri, May 23, 2014 at 11:05:17AM +0530, Tushar Behera wrote:
>
>> I tested with moving clk_enable/clk_disable calls to set_bias_level():
>> SND_SOC_BIAS_PREPARE. That works well for me. Does it look okay?
>
>> + if (!IS_ERR(max98090->mclk)) {
>> + if (codec->dapm.bias_level == SND_SOC_BIAS_ON)
>> + clk_disable(max98090->mclk);
>> + else
>> + clk_enable(max98090->mclk);
>> + }
>> break;
>
> Should be clk_prepare_enable() and similarly for the disable and you
> should check the error codes but yes, that looks good.

I was planning to keep clk_prepare/clk_unprepare in probe/remove.

We are not doing anything specific with the return codes here, so
might be I will add only a error message in case enable/disable fails.

--
Tushar Behera


\
 
 \ /
  Last update: 2014-05-23 14:21    [W:0.047 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site