lkml.org 
[lkml]   [2014]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] video: fbdev: grvga.c: Fix for possible null pointer dereference
On 21/05/14 00:35, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/video/fbdev/grvga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/grvga.c b/drivers/video/fbdev/grvga.c
> index c078701..2db5bb1 100644
> --- a/drivers/video/fbdev/grvga.c
> +++ b/drivers/video/fbdev/grvga.c
> @@ -514,9 +514,10 @@ free_fb:
> static int grvga_remove(struct platform_device *device)
> {
> struct fb_info *info = dev_get_drvdata(&device->dev);
> - struct grvga_par *par = info->par;
> + struct grvga_par *par;
>
> if (info) {
> + par = info->par;
> unregister_framebuffer(info);
> fb_dealloc_cmap(&info->cmap);
>

Thanks, queued this and the next one (video: fbdev: s3fb.c: Fix for
possible null pointer dereference) for 3.16.

Tomi



[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-05-23 13:41    [W:0.190 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site