lkml.org 
[lkml]   [2014]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 13/14] mmc: mmci: add qcom specific clk control
    From
    On Thu, May 15, 2014 at 11:37 AM,  <srinivas.kandagatla@linaro.org> wrote:

    > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    >
    > On Qcom SD card controller, cclk is mclk and mclk should be directly
    > controlled by the driver.
    > This patch adds support to control mclk directly in the driver, and also
    > adds explicit_mclk_control and cclk_is_mclk flags in variant structure giving
    > more flexibility to the driver.
    >
    > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    (...)
    > + bool qcom_cclk_is_mclk;

    I have no idea why you prefix that with "qcom" since it's an
    abstract concept.

    But it's a very minor issue, so:
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2014-05-23 12:01    [W:4.137 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site