Messages in this thread | | | Date | Thu, 22 May 2014 09:32:05 +0200 | From | Jonas Bonn <> | Subject | Re: [PATCH v2] openrisc: irq: use irqchip framework |
| |
On 05/21/2014 09:50 PM, Stefan Kristiansson wrote: > > I see two paths to go to get there though, and here's where I'd like some input. > 1) Define the three different implementations as seperate irqchips, > with accompanying IRQCHIP_DECLARE. > 2) Add custom device-tree bindings and determine the chip type from that.
I think 1) above is the way to go. Something alone the lines of "opencores,or1k-pic-level", "opencores,or1k-pic-edge", and "opencores,or1200-pic".
The first two match the behaviour of the or1k specification; the third one, however, is really a misimplementation of the spec and is kind of tied to the actual implementation of the OR1200... I wonder if we don't need to version this one like we version the CPU identifier (*-rtlsvnXXXXX).
/Jonas
| |