Messages in this thread Patch in this message | | | Date | Thu, 22 May 2014 05:27:36 -0700 | From | tip-bot for Dietmar Eggemann <> | Subject | [tip:sched/core] sched: Do not zero sg->cpumask and sg->sgp-> power in build_sched_groups() |
| |
Commit-ID: caffcdd8d27ba78730d5540396ce72ad022aff2c Gitweb: http://git.kernel.org/tip/caffcdd8d27ba78730d5540396ce72ad022aff2c Author: Dietmar Eggemann <Dietmar.Eggemann@arm.com> AuthorDate: Wed, 30 Apr 2014 14:39:38 +0100 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Thu, 22 May 2014 11:16:30 +0200
sched: Do not zero sg->cpumask and sg->sgp->power in build_sched_groups()
There is no need to zero struct sched_group member cpumask and struct sched_group_power member power since both structures are already allocated as zeroed memory in __sdt_alloc().
This patch has been tested with BUG_ON(!cpumask_empty(sched_group_cpus(sg))); and BUG_ON(sg->sgp->power); in build_sched_groups() on ARM TC2 and INTEL i5 M520 platform including CPU hotplug scenarios.
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/1398865178-12577-1-git-send-email-dietmar.eggemann@arm.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/sched/core.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 45d077e..6340c60 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5794,8 +5794,6 @@ build_sched_groups(struct sched_domain *sd, int cpu) continue; group = get_group(i, sdd, &sg); - cpumask_clear(sched_group_cpus(sg)); - sg->sgp->power = 0; cpumask_setall(sched_group_mask(sg)); for_each_cpu(j, span) {
| |