Messages in this thread | | | Date | Thu, 22 May 2014 14:15:54 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH v3] gpio: Add support for Intel SoC PMIC (Crystal Cove) |
| |
On Thu, May 22, 2014 at 12:59:03PM +0800, Zhu, Lejun wrote: > +static int crystalcove_gpio_probe(struct platform_device *pdev) > +{ > + int irq = platform_get_irq(pdev, 0); > + struct crystalcove_gpio *cg; > + int retval; > + struct device *dev = pdev->dev.parent; > + > + cg = devm_kzalloc(&pdev->dev, sizeof(*cg), GFP_KERNEL); > + if (!cg) {
A minor comment here:
return -ENOMEM;
> + retval = -ENOMEM; > + goto out; > + }
Other than that this looks good to me,
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
I suppose this is dependent on the MFD driver right? If so, this should probably be merged along with that patch.
| |