lkml.org 
[lkml]   [2014]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 4/5] arch/x86: Replace plain strings with constants
On Fri, 16 May, at 10:41:43PM, Daniel Kiper wrote:
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
> arch/x86/kernel/setup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index f41f648..7a67f5d 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -924,11 +924,11 @@ void __init setup_arch(char **cmdline_p)
> #endif
> #ifdef CONFIG_EFI
> if (!strncmp((char *)&boot_params.efi_info.efi_loader_signature,
> - "EL32", 4)) {
> + EFI32_LOADER_SIGNATURE, 4)) {
> set_bit(EFI_BOOT, &efi.flags);
> set_bit(EFI_DIRECT, &efi.flags);
> } else if (!strncmp((char *)&boot_params.efi_info.efi_loader_signature,
> - "EL64", 4)) {
> + EFI64_LOADER_SIGNATURE, 4)) {
> set_bit(EFI_BOOT, &efi.flags);
> set_bit(EFI_DIRECT, &efi.flags);
> set_bit(EFI_64BIT, &efi.flags);

Conceptually this change is a nice cleanup, but you've also changed the
indentation. Please don't do that, stick with the existing format.

--
Matt Fleming, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2014-05-22 10:21    [W:0.106 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site