lkml.org 
[lkml]   [2014]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] uprobes: Add mem_cgroup_charge_anon() into uprobe_write_opcode()
* Oleg Nesterov <oleg@redhat.com> [2014-05-05 17:13:20]:

> Hugh says:
>
> The one I noticed was that it forgets all about memcg (because
> it was copied from KSM, and there the replacement page has already
> been charged to a memcg). See how mm/memory.c do_anonymous_page()
> does a mem_cgroup_charge_anon().
>
> Hopefully not a big problem, uprobes is a system-wide thing and only
> root can insert the probes. But I agree, should be fixed anyway.
>
> Add mem_cgroup_{un,}charge_anon() into uprobe_write_opcode(). To simplify
> the error handling (and avoid the new "uncharge" label) the patch also
> moves anon_vma_prepare() up before we alloc/charge the new page.
>
> While at it fix the comment about ->mmap_sem, it is held for write.
>
> Suggested-by: Hugh Dickins <hughd@google.com>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

--
Thanks and Regards
Srikar Dronamraju



\
 
 \ /
  Last update: 2014-05-22 13:21    [W:0.047 / U:2.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site