Messages in this thread | | | Subject | Re: [PATCH 1/2] mISDN: Use time_before() | From | Joe Perches <> | Date | Wed, 21 May 2014 13:07:46 -0700 |
| |
On Wed, 2014-05-21 at 23:27 +0400, Sergei Shtylyov wrote: > On 05/21/2014 11:10 PM, Manuel Schölling wrote: > > To be future-proof and for better readability the time comparisons are modified > > to use time_before() instead of plain, error-prone math. > > diff --git a/drivers/isdn/mISDN/l1oip_core.c b/drivers/isdn/mISDN/l1oip_core.c [] > > @@ -287,7 +287,7 @@ l1oip_socket_send(struct l1oip *hc, u8 localcodec, u8 channel, u32 chanmask, > > p = frame; > > > > /* restart timer */ > > - if ((int)(hc->keep_tl.expires-jiffies) < 5 * HZ) { > > + if (time_before(hc->keep_tl.expires - 5 * HZ, jiffies)) { > > Wouldn't it be clearer this way: > > if (time_before(hc->keep_tl.expires, jiffies + 5 * HZ)) {
> > del_timer(&hc->keep_tl); > > hc->keep_tl.expires = jiffies + L1OIP_KEEPALIVE * HZ; > > add_timer(&hc->keep_tl);
mod_timer?
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |