Messages in this thread | | | Date | Wed, 21 May 2014 23:19:15 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] mm: /prom/pid/clear_refs: avoid split_huge_page() |
| |
On Wed, May 21, 2014 at 10:04:22PM +0300, Kirill A. Shutemov wrote: > Currently we split all THP pages on any clear_refs request. It's not > necessary. We can handle this on PMD level. > > One side effect is that soft dirty will potentially see more dirty > memory, since we will mark whole THP page dirty at once. > > Sanity checked with CRIU test suite. More testing is required. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Cc: Andrea Arcangeli <aarcange@redhat.com> > Cc: Pavel Emelyanov <xemul@parallels.com> > Cc: Cyrill Gorcunov <gorcunov@openvz.org> > Cc: Dave Hansen <dave.hansen@intel.com>
Looks reasonable to me, thanks!
Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
| |