lkml.org 
[lkml]   [2014]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch v4 4/5] ARM: dts: keystone: update reset node to work with reset driver

On 05/21/2014 05:50 PM, Arnd Bergmann wrote:
> On Wednesday 21 May 2014 17:27:33 Ivan Khoronzhuk wrote:
>> The keystone driver requires the next additional properties:
>>
>> "ti,syscon-pll" - syscon register range used to access pll controller
>> registers in order to use reset control registers.
>> "ti,syscon-dev" - syscon register range used to access device state
>> control registers in order to use mux block
>> registers for all watchdogs.
>>
>> "ti,wdt_list" - option to declare what watchdog are used to reboot
>> the SoC, so set "0" WDT as default.
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> Same comment as what I had for the binding: it's not a register range
> any more, but a phandle for a device.
>
>> ---
>> arch/arm/boot/dts/keystone.dtsi | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
>> index 8b899ba..783da60 100644
>> --- a/arch/arm/boot/dts/keystone.dtsi
>> +++ b/arch/arm/boot/dts/keystone.dtsi
>> @@ -78,7 +78,9 @@
>>
>> rstctrl: reset-controller {
>> compatible = "ti,keystone-reset";
>> - reg = <0x023100e8 4>; /* pll reset control reg */
>> + ti,syscon-pll = <&pllctrl>;
>> + ti,syscon-dev = <&devctrl>;
>> + ti,wdt_list = <0>;
>> };
>>
> I don't see a definition for the two labels, so this will cause a
> build error. It makes sense to add them in the same patch.
>
> Arnd

Thanks,

I'll correct

--
Regards,
Ivan Khoronzhuk



\
 
 \ /
  Last update: 2014-05-21 18:41    [W:0.236 / U:1.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site