Messages in this thread | | | Date | Wed, 21 May 2014 12:38:46 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 5/6] x86, nmi: Move default external NMI handler to its own routine |
| |
On Thu, May 15, 2014 at 03:25:48PM -0400, Don Zickus wrote: > Now that we have setup an NMI subtye called NMI_EXT, there is really > no need to hard code the default external NMI handler in the main > nmi handler routine. > > Move it to a proper function and register it on boot. This change is > just code movement. > > In addition, update the hpwdt to allow it to unregister the default > handler on its registration (and vice versa). This allows the driver > to take control of that io port (which it ultimately wanted to do > originally), but in a cleaner way.
wanting that is one thing, but is it also a sane thing? You don't do thing just because drivers want it.
| |