lkml.org 
[lkml]   [2014]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
> Adds additional nodes to support GPLDO1-6 and VBUS regulators which
> are now supported in the bcm590xx regulator driver.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
> ---
> arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)

I'm not going to apply this with the rest of the set. It will have to
go in via your normal arch/arm route.

> diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> index dfadaaa..066adfb 100644
> --- a/arch/arm/boot/dts/bcm59056.dtsi
> +++ b/arch/arm/boot/dts/bcm59056.dtsi
> @@ -70,5 +70,26 @@
>
> vsr_reg: vsr {
> };
> +
> + gpldo1_reg: gpldo1 {
> + };

What do these empty nodes do in any case?

Don't you at least need a status property in there or something?

> + gpldo2_reg: gpldo2 {
> + };
> +
> + gpldo3_reg: gpldo3 {
> + };
> +
> + gpldo4_reg: gpldo4 {
> + };
> +
> + gpldo5_reg: gpldo5 {
> + };
> +
> + gpldo6_reg: gpldo6 {
> + };
> +
> + vbus_reg: vbus {
> + };
> };
> };

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-05-21 12:41    [W:0.148 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site