lkml.org 
[lkml]   [2014]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Patch v3 0/5] Introduce keystone reset driver
Date
On Tuesday 20 May 2014 21:35:23 Ivan Khoronzhuk wrote:
> Thank for the note.
>
> Ok.
>
> Memory map:
> [00 02310000 - 00 023101FF] size=512 PLL Controller
> [00 02620000 - 00 02620FFF] size=4K device state control registers
>
> I'll define in DT two new syscon compatible nodes like:
>
> pllctrl: pll_controller {
> compatible = "syscon";
> reg = <0x2310000 0x200>;
> };
>
> devctrl: device_state_control {
> compatible = "syscon";
> reg = <0x2620000 0x1000>;
> };

Please add a well-defined compatible-string in addition to "syscon" as
well.

> then correct reset-controller node like:
>
> rstctrl: reset-controller {
> compatible = "ti,keystone-reset";
> reg = <0xE4 0x10>, <0x328 0x10>;
> reg-names = "pllregs", "muxregs";
> syscon1 = <&pllctrl>;
> syscon2 = <&devctrl>;
> ti,wdt_list = <0>;
> };

You can't really use the "reg" property to refer to syscon
registers, but you can make up your own property for that,
or put the register numbers into the syscon1/2 properties,
or just hardcode the offsets in the driver.

> And correct reset-controller code to get regmap by phandle,
> then access registers by regmap.
>
> Also I'll post two separate patches that add syscon nodes in question.

Sounds good, thanks!

Arnd


\
 
 \ /
  Last update: 2014-05-20 21:41    [W:0.124 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site