lkml.org 
[lkml]   [2014]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] earlyprintk=efi,keep fix
On Thu, 01 May, at 09:15:48PM, Dave Young wrote:
>
> earlyprintk=efi,keep will cause kernel hangs while freeing initmem like below:
> [ 2.826089] VFS: Mounted root (ext4 filesystem) readonly on device 254:2.
> [ 2.846592] devtmpfs: mounted
> [ 2.856974] Freeing unused kernel memory: 880K (ffffffff817d4000 - ffffffff818b0000)
>
> It is caused by efi earlyprintk use __init function which will be freed later.
> Such as early_efi_write is marked as __init, also it will use early_ioremap
> which is init function as well.
>
> To fix this issue, I added early initcall early_efi_map_fb which maps the whole
> efi fb for later use. OTOH, adding a wrapper function early_efi_map which calls
> early_ioremap before ioremap is available.
>
> With this patch applied efi boot ok with earlyprintk=efi,keep console=efi
>
> Signed-off-by: Dave Young <dyoung@redhat.com>
> ---
> arch/x86/platform/efi/early_printk.c | 83 ++++++++++++++++++++++++++---------
> 1 file changed, 64 insertions(+), 19 deletions(-)

Thanks Dave, applied!

--
Matt Fleming, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2014-05-02 15:41    [W:0.034 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site