Messages in this thread | | | From | David Matlack <> | Date | Mon, 19 May 2014 08:57:49 -0700 | Subject | Re: [PATCH 2/2] staging: slicoss: remove slic_reg_params struct |
| |
On Mon, May 19, 2014 at 2:21 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > Looking at the patch, this looks like a bugfix but the changelog doesn't > give any clues.
Yeah this isn't a bug fix.
The only member of struct slic_reg_params that was in use was fail_on_bad_eeprom (implicitly set to zero by alloc_etherdev -> kzalloc). Since the previous patch in this series fixes the eeprom checksum, we can remove this struct entirely.
If we do want the feature of ignoring a corrupt/bad eeprom, a module param would work better anyway.
| |