lkml.org 
[lkml]   [2014]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/5] usb: gadget: net2280: Code Cleanup
Hello Alan


I am trying to be consistent around the file. On a previous patch I
was asked to move the operators at the end. I did so, and now I am
modifying the file to look alike.



On Mon, May 19, 2014 at 9:43 PM, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
>
>> Move logical continuations to end of line
>
> This is almost totally unnecessary. Some people prefer the
> operators at the end of the first line, other people prefer them at the
> start of the next line. It's just a matter of taste and it doesn't
> matter.
>
>> @@ -402,8 +402,8 @@ static void ep_reset_228x(struct net2280_regs __iomem *regs,
>> BIT(DATA_PACKET_RECEIVED_INTERRUPT) |
>> BIT(DATA_PACKET_TRANSMITTED_INTERRUPT) |
>> BIT(DATA_OUT_PING_TOKEN_INTERRUPT) |
>> - BIT(DATA_IN_TOKEN_INTERRUPT)
>> - , &ep->regs->ep_stat);
>> + BIT(DATA_IN_TOKEN_INTERRUPT),
>> + &ep->regs->ep_stat);
>
> This is an example of the one type of change that does make sense.
> Nobody should start lines with a ','.
>
> Alan Stern
>



--
Ricardo Ribalda


\
 
 \ /
  Last update: 2014-05-19 22:41    [W:0.055 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site