lkml.org 
[lkml]   [2014]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] ARM: imx: fix error handling in ipu device registration
On Sat, May 17, 2014 at 11:35:55PM +0100, Russell King - ARM Linux wrote:
> On Sun, May 18, 2014 at 01:08:36AM +0300, Dan Carpenter wrote:
> > Let's look at that error handling again.
> >
> > err: <-- the name is not descriptive. the location is bad.
> > kfree(pdev->dev.dma_mask); <- null dereference.
> > platform_device_put(pdev); <- ok
> > return ERR_PTR(-ENODEV); <- should be "return ERR_PTR(ret);"
> >
> > 3 out of 4 of the lines are bad.
>
> 2 out of 4. kfree(NULL) is perfectly legal.

pdev was NULL though...

The bug is *caused* by trying to use the same "err" label to do all
error handling. This is a very common anti-patern, but if you follow
canonical kernel style then your error handling is less buggy.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-05-18 01:41    [W:0.107 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site