lkml.org 
[lkml]   [2014]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] cpupower: Remove redundant error check
On Sun, May 18, 2014 at 12:31:29AM +0200, Peter Senna Tschudin wrote:
> >
> > I am currently involved in a number of threads, not just yours, where I
> > am encouraging people to replace ambiguous returns with "return 0;".
> > This is my life now.
> So maybe you like this list of 160 places in which the return variable
> is initialized and only used as parameter to return(The list look
> good, but I haven't reviewed all 160, so there could be problems):
> http://pastebin.com/5kAbCP2e

Fantastic! :) These things are easy to review because if it's wrong
then the compile will break.

>
> Does it worth doing something about those trivial cases?
>
> Do you have more examples of ambiguous returns, so I can help you hunt them?

The main thing is what your check finds. If you know that ret is zero
then return zero.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-05-18 01:21    [W:0.060 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site