Messages in this thread | | | Date | Sat, 17 May 2014 22:14:52 +0100 | Subject | Re: [PATCH 3/4] staging: dgnc: dgnc_neo: Fix conditional part of if statement | From | Masaru Nomura <> |
| |
Hi Dan,
Thank you for your detailed explanation!
> This isn't the right way. Write it like this: > > if ((ch->ch_digi.digi_flags & CTSPACE) || > (ch->ch_digi.digi_flags & RTSPACE) || > (ch->ch_c_cflag & CRTSCTS) || > !(ch->ch_digi.digi_flags & DIGI_FORCEDCD) || > !(ch->ch_c_cflag & CLOCAL)) { > ier |= UART_IER_MSI; > else > ier &= ~UART_IER_MSI; > > 1) The "||" operation goes at the end of the line. > 2) The conditions are all in a line. The indenting is > > [tab][space][space][space][space](ch->ch_digi.digi_f...
Sure, I'll modify this.
> Also just fold this patch and [patch 2/4] together into one patch. We > don't need two patches to fix one if statement. > > The one thing per patch rule is a bit tricky. It means that you have to > say which one thing you are fixing. Don't say "I am fixing three > things." Say "I am fixing one if statement".
So in this case, do you think I could fold all four patches into one? As I just worked on the 'same' if statements and divided them into four patches, this could be the case. (but I'm not sure yet...)
Also, should I put v[number] for the modified patches? Say [PATCH v2] staging: ...
Thank you, Masaru
| |