lkml.org 
[lkml]   [2014]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] staging: media: as102: replace custom dprintk() with dev_dbg()
On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
> don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
> use the common kernel coding style.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>

Reviewed-by: Antti Palosaari <crope@iki.fi>

> ---
> this applies to next-20140516. any more suggestions?
> more cleanup can be done when dprintk() is completely gone.

Do you have the device? I am a bit reluctant patching that driver
without any testing as it has happened too many times something has gone
totally broken.

IIRC Devin said it is in staging because of style issues and nothing
more. Is that correct?

regards
Antti

--
http://palosaari.fi/


\
 
 \ /
  Last update: 2014-05-17 19:41    [W:0.258 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site