Messages in this thread | | | Subject | Re: [PATCH v4 2/8] OF: Introduce DT overlay support. | From | Pantelis Antoniou <> | Date | Thu, 15 May 2014 00:15:23 -0700 |
| |
Hi Guenter,
On May 14, 2014, at 6:18 AM, Guenter Roeck wrote:
> On 05/14/2014 06:03 AM, Geert Uytterhoeven wrote: >> On Wed, May 14, 2014 at 12:08 PM, Grant Likely >> <grant.likely@secretlab.ca> wrote: >>>> +config OF_OVERLAY >>>> + bool "OF overlay support" >>>> + depends on OF >>>> + select OF_DYNAMIC >>>> + select OF_DEVICE >>>> + select OF_RESOLVE >>>> + help >>>> + OpenFirmware overlay support. Allows you to modify on runtime the >>>> + live tree using overlays. >>> >>> Should not be a user-visable option. Drivers using it should select it >> >> Why not? It's up to the (final) user to use it, or not. >> >>> or otherwise cause it to be enabled. >> >> Why should this be driver-specific? Shouldn't this just work with all drivers? >> > > It does once enabled. > > I think what Grant refers to is that there has to be a driver which implements > the actual overlay insertion and removal (ie calls the new API functions), > and that the Kconfig option for this driver should select OF_OVERLAY > instead of depending on it. >
That makes sense.
> Guenter >
Regards
-- Pantelis
| |