Messages in this thread | | | Date | Thu, 15 May 2014 22:51:23 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2 |
| |
On Wed, May 14, 2014 at 02:50:47PM +0900, Namhyung Kim wrote: > On Mon, 12 May 2014 15:51:14 -0700, Andi Kleen wrote: > > From: Andi Kleen <ak@linux.intel.com> > > > > Fix the logic to allow overriding event default periods with -c or -F > > on the command line. I'm not sure I understand this if() fully, but > > this change makes all cases I tested work (tracepoint with default, default, > > ,-c, -F) > > > > This fixed specifying -c / -F with json event list events, > > which have a default period. It should do the same > > for trace point events. > > Hmm.. doesn't that require both -c and -F are given at the same time?
I don't think so.
> > Anyway, there was a similar discussion, but I suggested an other way. > Please see the line below.
I had tried a couple of combinations earlier, this was the one that worked in all cases.
-Andi
| |