lkml.org 
[lkml]   [2014]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: staging: line6: Add blank lines after declarations
On Tue, May 13, 2014 at 02:02:01PM +0200, Greg KH wrote:
> On Wed, May 14, 2014 at 02:56:42AM +0300, Artem Fetishev wrote:
> > Use the more common kernel coding style.
> >
> > Signed-off-by: Artem Fetishev <wwctrsrx@gmail.com>
> > ---
> > drivers/staging/line6/capture.c | 4 ++++
> > drivers/staging/line6/midi.c | 2 ++
> > drivers/staging/line6/playback.c | 5 +++++
> > drivers/staging/line6/pod.c | 5 +++++
> > drivers/staging/line6/toneport.c | 2 ++
> > drivers/staging/line6/variax.c | 2 ++
> > 6 files changed, 20 insertions(+)
> >
> > diff --git a/drivers/staging/line6/capture.c b/drivers/staging/line6/capture.c
> > index 0eda51d..14ed0d7 100644
> > --- a/drivers/staging/line6/capture.c
> > +++ b/drivers/staging/line6/capture.c
> > @@ -97,6 +97,7 @@ void line6_unlink_audio_in_urbs(struct snd_line6_pcm *line6pcm)
> > if (test_bit(i, &line6pcm->active_urb_in)) {
> > if (!test_and_set_bit(i, &line6pcm->unlink_urb_in)) {
> > struct urb *u = line6pcm->urb_audio_in[i];
> > +
> > usb_unlink_urb(u);
> > }
> > }
> > @@ -122,6 +123,7 @@ void line6_wait_clear_audio_in_urbs(struct snd_line6_pcm *line6pcm)
> > if (!alive)
> > break;
> > set_current_state(TASK_UNINTERRUPTIBLE);
> > +
> > schedule_timeout(1);
> > } while (--timeout > 0);
> > if (alive)
>
> That line doesn't look like it needs to be added, why do so?
>

I've removed that new line in v2 of the patch. I sent it two days ago.


\
 
 \ /
  Last update: 2014-05-15 09:21    [W:0.024 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site