Messages in this thread | | | Date | Thu, 15 May 2014 15:45:23 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH v5 UPDATED 3/3] CPU hotplug, smp: Flush any pending IPI callbacks before CPU offline |
| |
On Fri, May 16, 2014 at 01:13:18AM +0530, Srivatsa S. Bhat wrote: > On 05/16/2014 01:06 AM, Paul E. McKenney wrote: > > On Fri, May 16, 2014 at 12:56:11AM +0530, Srivatsa S. Bhat wrote: > >> On 05/16/2014 12:49 AM, Tejun Heo wrote: > >>> Hello, > >>> > >>> On Fri, May 16, 2014 at 12:44:13AM +0530, Srivatsa S. Bhat wrote: > >>>> /* > >>>> + * flush_smp_call_function_queue - Flush any pending smp-call-function > >>> > >>> Don't we need a blank line here? > >> > >> Hmm? That sentence continues on the next line, hence I didn't add any blank > >> line there. > > > > Tejun might be wanting this to be a docbook comment, in which case > > it also needs "/**" at the beginning of the comment. > > > > Oh, I see. Like this?
Yeah, looks good to me.
Thanks.
-- tejun
| |