Messages in this thread | | | Date | Thu, 15 May 2014 16:15:32 +0530 | Subject | Re: Format of patches (was: [PATCH 1/2] speedstep-smi: enable interrupts when waiting) | From | Viresh Kumar <> |
| |
On 15 May 2014 16:07, Mikulas Patocka <mpatocka@redhat.com> wrote: > On Thu, 15 May 2014, Viresh Kumar wrote: >> On 14 May 2014 19:54, Mikulas Patocka <mpatocka@redhat.com> wrote: >> > Hi Viresh >> > >> > Some times ago, I sent these two cpufreq patches to fix frequency >> > transition problem on speedstep-smi, but you didn't put them to the >> > upstream kernel. I am resending the patches. If you would like a different >> > solution to this problem, please explain it. >> >> Probably these are just missed by Rafael. The patches are fine but the >> above paragraph you wrote would get into kernel logs and must have >> been placed below the three dash lines: "---" > > I used "---" in the past, but some people complained that their script > picks the text above "---" and ignores the text below "---" - thus, it > does exactly the opposite of what it should do.
Have you added an extra line with --- ? Probably yes. I haven't asked you to add another line, but move the part you don't want to be commited below --- already present in patch..
Like:
> ---
Blurb here :)
> drivers/cpufreq/speedstep-lib.c | 3 +++ > drivers/cpufreq/speedstep-smi.c | 12 ++++++++++++ > 2 files changed, 15 insertions(+) >
> I don't know what kind of delimiter should I use. Suppose that I want to > send something like this:
Will go through below mail of yours once we are clear on above..
| |