Messages in this thread | | | From | Vincent Guittot <> | Date | Thu, 15 May 2014 09:41:11 +0200 | Subject | Re: [PATCH 0/6] sched: expel confusing usage of the term "power" |
| |
Hi Nico,
Thanks for doing this renaming. I remember that you asked me to do this while working on cpu_power but my work has not evolved as fast as expected and as it already implies some renaming other than s/power/capacity/ i have postponed it to not make review to complex.
Nevertheless, i can manage the conflicts afterward and rebase my patches, depending of the review status
Vincent
On 14 May 2014 22:57, Nicolas Pitre <nicolas.pitre@linaro.org> wrote: > "Power" is a very bad term in the scheduler context. There are so many > meanings that can be attached to it. And with the upcoming "power > aware" scheduler work confusion is sure to happen. > > The definition of "power" is typically the rate at which work is performed, > energy is converted or electric energy is transferred. The notion of > "compute capacity" is rather at odds with "power" to the point many > comments in the code have to make it explicit that "capacity" is the > actual intended meaning. > > So let's make it clear what we man by using "capacity" in place of "power" > directly in the code. That will make the introduction of actual "power > consumption" concepts much clearer later on. > > This is based on the latest tip tree where scheduler changes are already > queued. > > Note: The diffstat is not completely symetric wrt added/removed lines as > some comments were reflowed. > > > arch/arm/kernel/topology.c | 54 +++---- > include/linux/sched.h | 8 +- > kernel/sched/core.c | 89 ++++++----- > kernel/sched/fair.c | 322 ++++++++++++++++++++------------------- > kernel/sched/sched.h | 18 +-- > 5 files changed, 246 insertions(+), 245 deletions(-) > > > Nicolas
| |