Messages in this thread | | | Date | Wed, 14 May 2014 07:45:33 +0100 | From | Srinivas Kandagatla <> | Subject | Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID. |
| |
On 13/05/14 23:13, Stephen Boyd wrote: > On 05/13, Srinivas Kandagatla wrote: >> Thanks Linus W, >> >> On 13/05/14 08:16, Linus Walleij wrote: >>> On Tue, Apr 29, 2014 at 10:19 AM, <srinivas.kandagatla@linaro.org> wrote: >>> >>>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >>>> >>>> This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci >>>> driver. >>>> >>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >>> (...) >>>> + AMBA_VENDOR_QCOM = 0x51, >>> >>> Yeah it's a "Q", like 0x41 is "A" for ARM. You could as well mention >>> this in the commit message. >>> >> Sounds good, I will fix it in next version and send it to Russell's >> patch tracker. >> > > Please add a note that this id is fake in the commit text or in > the code as well. Sure, I will add it in commit text.
>
| |