Messages in this thread | | | Date | Tue, 13 May 2014 21:41:25 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 4/7] acpi, apei, ghes: Factor out NMI error notification context. |
| |
On Wed, Apr 09, 2014 at 05:14:32PM +0200, Tomasz Nowicki wrote: > Use CONFIG_ACPI_APEI_NMI to isolate NMI error notification path. NMI related > data and functions are grouped so they can be wrapped inside one > > Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org> > --- > drivers/acpi/apei/ghes.c | 54 +++++++++++++++++++++++++--------------------- > 1 file changed, 30 insertions(+), 24 deletions(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index ca8387e..7a0d66e 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -53,7 +53,9 @@ > #include <asm/mce.h> > #endif > #include <asm/tlbflush.h> > +#ifdef CONFIG_ACPI_APEI_NMI > #include <asm/nmi.h> > +#endif
This, again, can be avoided with adding arch-specific versions and empty default stubs.
> #include "apei-internal.h"
... -- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |