lkml.org 
[lkml]   [2014]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] fs/devpts/inode.c: convert printk to pr_foo()
From
Date
On Tue, 2014-05-13 at 18:13 +0200, Fabian Frederick wrote:
> Also convert spaces to tabs (checkpatch warnings)
[]
> diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
[]

It may be better to add a #define pr_fmt

> @@ -225,7 +225,7 @@ static int parse_mount_options(char *data, int op, struct pts_mount_opts *opts)
> break;
> #endif
> default:
> - printk(KERN_ERR "devpts: called with bogus options\n");
> + pr_err("devpts: called with bogus options\n");

and remove all the embedded "devpts: "

> @@ -261,7 +261,7 @@ static int mknod_ptmx(struct super_block *sb)
>
> dentry = d_alloc_name(root, "ptmx");
> if (!dentry) {
> - printk(KERN_NOTICE "Unable to alloc dentry for ptmx node\n");
> + pr_notice("Unable to alloc dentry for ptmx node\n");
> goto out;
> }
>
> @@ -270,7 +270,7 @@ static int mknod_ptmx(struct super_block *sb)
> */
> inode = new_inode(sb);
> if (!inode) {
> - printk(KERN_ERR "Unable to alloc inode for ptmx node\n");
> + pr_err("Unable to alloc inode for ptmx node\n");
> dput(dentry);
> goto out;
> }

Adding pr_fmt would prefix these.

It seems odd that one of these is an err and the other a notice.




\
 
 \ /
  Last update: 2014-05-13 19:01    [W:0.039 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site