Messages in this thread | | | Date | Tue, 13 May 2014 15:30:50 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH 17/19] fs: buffer: Do not use unnecessary atomic operations when discarding buffers |
| |
On Tue, May 13, 2014 at 03:49:43PM +0200, Jan Kara wrote: > > > operation which is available on a lot of architectures, we'll be stuck > > > with a cmpxchg loop instead :/ > > > > > > *sigh* > > > > > > Anyway, nothing wrong with this patch, however, you could, if you really > > > wanted to push things, also include BH_Lock in that clear :-) > > > > That's a bold strategy Cotton. > > > > Untested patch on top > Although this looks correct, I have to say I prefer the explicit > unlock_buffer() unless this has a measurable benefit. >
I will keep this as a separate patch, move it to the end of the series and check what the profiles look like. Thanks.
-- Mel Gorman SUSE Labs
| |