lkml.org 
[lkml]   [2014]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 17/19] fs: buffer: Do not use unnecessary atomic operations when discarding buffers
On Tue, May 13, 2014 at 03:49:43PM +0200, Jan Kara wrote:
> > > operation which is available on a lot of architectures, we'll be stuck
> > > with a cmpxchg loop instead :/
> > >
> > > *sigh*
> > >
> > > Anyway, nothing wrong with this patch, however, you could, if you really
> > > wanted to push things, also include BH_Lock in that clear :-)
> >
> > That's a bold strategy Cotton.
> >
> > Untested patch on top
> Although this looks correct, I have to say I prefer the explicit
> unlock_buffer() unless this has a measurable benefit.
>

I will keep this as a separate patch, move it to the end of the series
and check what the profiles look like. Thanks.

--
Mel Gorman
SUSE Labs


\
 
 \ /
  Last update: 2014-05-13 17:01    [W:0.149 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site