lkml.org 
[lkml]   [2014]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [E1000-devel] [PATCH] e1000: remove the check: skb->len<=0
Date
> -----Original Message-----
> From: xuyongjiande@gmail.com [mailto:xuyongjiande@gmail.com]
> Sent: Monday, May 12, 2014 10:07 PM
> To: eric.dumazet@gmail.com
> Cc: e1000-devel@lists.sourceforge.net; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Yongjian Xu
> Subject: [E1000-devel] [PATCH] e1000: remove the check: skb->len<=0
>
> From: Yongjian Xu <xuyongjiande@gmail.com>
>
> There is no case skb->len would be 0 or 'negative'.
> Remove the check.
>
> Signed-off-by: Yongjian Xu <xuyongjiande@gmail.com>
> ---
> drivers/net/ethernet/intel/e1000/e1000_main.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c
> b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 27058df..660971f 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> @@ -3105,11 +3105,6 @@ static netdev_tx_t e1000_xmit_frame(struct
> sk_buff *skb,
> */
> tx_ring = adapter->tx_ring;
>
> - if (unlikely(skb->len <= 0)) {
> - dev_kfree_skb_any(skb);
> - return NETDEV_TX_OK;
> - }
> -
> /* On PCI/PCI-X HW, if packet size is less than ETH_ZLEN,
> * packets may get corrupted during padding by HW.
> * To WA this issue, pad all small packets manually.
> --
> 1.9.1
What is the exact problem that this is fixing? Did you have a test case that showed a problem with it?

Cheers,
John




\
 
 \ /
  Last update: 2014-05-17 14:21    [W:0.149 / U:1.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site