Messages in this thread | | | Subject | Re: [PATCH 1/1] net/wireless/ibss.c: replace memcpy by ether_addr_copy | From | Joe Perches <> | Date | Mon, 12 May 2014 11:07:09 -0700 |
| |
On Mon, 2014-05-12 at 20:00 +0200, Fabian Frederick wrote: > On Mon, 12 May 2014 10:50:25 -0700 > Joe Perches <joe@perches.com> wrote: > > > On Mon, 2014-05-12 at 19:30 +0200, Fabian Frederick wrote: > > > This patch also fixes some comment checkpatch warnings > > > > Hello Fabian. > > > > For all the patches that replace memcpy(foo, bar, ETH_ALEN) > > with ether_addr_copy, did you use a tool to verify both > > arguments are __aligned(2) or did you do the verification > > visually? > > Hello Joe, > > I only replaced ETH_ALEN/memcpy . > AFAICS ETH_ALEN is defined 6 ...
The difference here is that both arguments to ether_addr_copy, like all the is_<foo>_ether_addr helpers, must be __aligned(2). memcpy has no alignment requirement.
Please verify that all these changes are to __aligned(2) arguments.
| |