Messages in this thread | | | Date | Mon, 12 May 2014 10:16:59 +0530 | From | Tushar Behera <> | Subject | Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT |
| |
On 05/10/2014 09:21 AM, Pankaj Dubey wrote: > On 05/09/2014 10:00 PM, Tushar Behera wrote: >> All SoC in Exynos-series have a clock with name XCLKOUT to provide >> debug information about various clocks available in the SoC. The register >> controlling the MUX and GATE of this clock is provided within PMU domain. >> Since PMU domain can't be dedicatedly mapped by every driver, the >> register >> needs to be handled through a regmap handle provided by PMU syscon >> controller. Right now, CCF doesn't allow regmap based MUX and GATE >> clocks, >> hence a dedicated clock provider for XCLKOUT is added here. >> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org> >> CC: Tomasz Figa <t.figa@samsung.com> >> --- >> drivers/clk/samsung/Makefile | 2 +- >> drivers/clk/samsung/clk-out.c | 181 >> +++++++++++++++++++++++++++++++++++++++++ >> drivers/clk/samsung/clk.h | 33 ++++++++ >> 3 files changed, 215 insertions(+), 1 deletion(-) >> create mode 100644 drivers/clk/samsung/clk-out.c >>
[ ... ]
>> +/** >> + * struct samsung_clkout_soc_data: SoC specific register details >> + * @reg: Offset of CLKOUT register from PMU base > > how about naming this variable as "offset" instead of "reg". >
Okay, I will change that.
[ ... ]
>> +u8 samsung_clkout_get_parent(struct clk_hw *hw) >> +{ >> + struct samsung_clkout *clkout = to_clk_out(hw); >> + const struct samsung_clkout_soc_data *soc_data = clkout->soc_data; >> + unsigned int parent_mask = BIT(soc_data->mux_width) - 1; >> + unsigned int val; >> + int ret; >> + >> + ret = regmap_read(clkout->regmap, soc_data->reg, &val); > > Do we really need to keep return value in "ret" as I can't see you are > using it anywhere? >
Right, we are not using that and can be removed.
>> + >> + return (val >> soc_data->mux_shift) & parent_mask; >> +} >> +
[ ... ]
>> +/* All existing Exynos serial of SoCs have common values for this >> offsets. */ > typo: serial/series/
Sure. Thanks for your review.
-- Tushar Behera
| |